Unexpected behaviour of escaped pipe in table

asciidoctor / atom-asciidoc-preview

⚛ AsciiDoc preview for the Atom editor.

https://atom.io/packages/asciidoc-preview

MIT License

141 stars 42 forks source link

Unexpected behaviour of escaped pipe in table #287

Closed HMKnapp closed 5 years ago

HMKnapp commented 5 years ago

Description

Escaped table separator in table cell has unexpected behaviour in preview when not at the end of a line (but works fine with Ruby asciidoctor cli html5 v1.5.7.1)

Atom version: 1.34.0
OS: Windows 10
asciidoc-preview version: 2.12.2
language-asciidoc version: 1.11.0

Screenshots

Unexpected

Expected

Syntax example

.Unexpected
|===
| a b \| c
|===

.Expected
|===
| a b \|
  c
|===

mojavelinux commented 5 years ago

This is a known issue in Asciidoctor.js that will be solved once it's upgraded. (It was a regular expression error that affected Asciidoctor.js / Opal).

cc: @Mogztter

HMKnapp commented 5 years ago

Thanks a lot for your quick replies and overall attitude towards bug reports. Outstanding!

mojavelinux commented 5 years ago

:+1:

mojavelinux commented 5 years ago

@Mogztter What's the status on the upgrade of Asciidoctor in this plugin. Could we at least move to 1.5.8 while we're waiting for 2.0.0 to materialize? I don't really see any reason why we're sticking to 1.5.6.

ggrossetie commented 5 years ago

@mojavelinux I think we've never took the time to upgrade but it should be pretty straightforward. I will give it a try :wink:

mojavelinux commented 5 years ago

Thanks @Mogztter!!