asciidoctor / atom-asciidoc-preview

⚛ AsciiDoc preview for the Atom editor.
https://atom.io/packages/asciidoc-preview
MIT License
142 stars 42 forks source link

The foldable details summary div doesn't work #299

Open Foadsf opened 4 years ago

Foadsf commented 4 years ago

Description

The foldable directive doesn't work.

Screenshots

the same code in both Atom and VSCode:

2019-10-18_12-50-17

Syntax example

+++ <details><summary> +++
some description
+++ </summary><div> +++
this
is
going
to be
folded
+++ </div></details> +++

the original source code can be found here.

ggrossetie commented 4 years ago

With the latest version of Asciidoctor you can write the following:

.some description
[%collapsible]
====
this
is
going
to be
folded
====

collapse

Foadsf commented 4 years ago

So the former syntax is deprecated? I prefer not to touch that code at the moment!

ggrossetie commented 4 years ago

Yes. Using passthrough to include raw HTML is not recommended because now your document is tightly coupled with the output.

Foadsf commented 4 years ago

@Mogztter mentioned your point here as well. That page, at least for me is the first google search result when searching for "asciidoc collapsible".

ggrossetie commented 4 years ago

Thanks! For reference it was introduced in Asciidoctor 2.0.0: https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.0