search

asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

feat: use Shadow DOM #107

Closed ldez closed 8 years ago

ldez commented 8 years ago

the shadow DOM is now enabled by default to prevent style pollution in Atom’s text editor component.

http://blog.atom.io/2015/01/05/enable-shadow-dom.html

nicorikken commented 8 years ago

If I understand correctly, this prevents styling conflicts with other packages, because the style is now sort of 'contained' in its own root. Seems like a good practice. Is there any way I can test this before the merge? The code itself seems simple enough.

ldez commented 8 years ago

There's no easy way to test this.

nicorikken commented 8 years ago

Alright, I'll merge this then, based on unit tests and associated documentation.