asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

feat: add mark support #128

Closed ldez closed 8 years ago

ldez commented 8 years ago

Description

http://asciidoctor.org/docs/user-manual/#custom-styling-with-attributes

Syntax example

.foobar
[role]**foo** bar
[role]*foo* bar
[role]__foo__ bar
[role]_foo_ bar
[role]##foo## bar
[role role2]#foo# bar
[role]``foo`` bar
[role]`foo` bar
[role]^foo^bar^foo^bar
[role]~foo~bar~foo~bar

Screenshots

capture du 2016-05-16 21-55-19

mojavelinux commented 8 years ago

Nice job!

Mark without a role becomes the mark element in HTML, which appears as highlighted text. Would it be possible to style it that way in the theme? (basically by reversing the background and foreground colors).

ldez commented 8 years ago

Like that ? :smile:

capture du 2016-05-16 23-44-49

[role role2]##foo## bar
[.role#id]##foo## bar
##foo## bar
#foo# bar
mojavelinux commented 8 years ago

Yes! \o/

mojavelinux commented 8 years ago

I think we're in good shape. @nicorikken, what say you?

nicorikken commented 8 years ago

Somehow I haven't been able to get the highlight to work under my theme. But syntax highlighting looks good. LGTM!

ldez commented 8 years ago

I have try with different themes, which theme are you using ?

nicorikken commented 8 years ago

I tried Seti, Atom One Dark, Atom One Light.

ldez commented 8 years ago

one-dark: one-dark

one-light: one-light

seti: seti

nicorikken commented 8 years ago

Apparently I did not check with the latest code. Now it does work properly 👍