Closed ldez closed 8 years ago
:+1:
Do you think we should highlight the whole phrase, or would that be distracting? (VIM highlights the whole phrase).
only the quotes are affected, the render of the phrase is not affected. this seems more proper.
wdyt ?
I'm not sure. That's the question I'm asking. We may need to seek input from other people to know what to do. It seems like a clear case for "quoted string".
@nicorikken any thoughts?
I misspoke: the final render in HTML for example, two characters are replaced by a single quotation mark but the content does not change rendering.
highlighting the whole phrase:
This feature of Asciidoctor is new to me. As the string inbetween the quotes is not affected in terms of style, highlighting the string itself seems odd to me. Or will it normalize other types of styling? Based on a small test I get the sense something is going wrong:
a "`test`" b
a *"`test`"* b
If only the quotes are affected, maybe they need to be made bold, to show off the highlighting more clearly?
As the string in between the quotes is not affected in terms of style, highlighting the string itself seems odd to me.
Correct, the string in between is not affected. This syntax simply makes the quotes curved. But, like in programming, it represents a "type" (a quoted string) and we're used to seeing something that is a string highlighted as such.
I'm trying to think about what would be least distracting for the author. Maybe if we made the quotes gray or slightly transparent and left the phrase itself alone, that would be better. Or perhaps we should match, but not style by default. It's hard to say because this is new territory.
"`What kind of charm?`" Lazarus asked. "`An odoriferous one or a mineral one?`"
When I read the documentation I understand that using context is near of quotes
Rethinking it, having a little highlighting probably wouldn't mind, as the quotes do equate to the content they encapsulate. Because the quotes have an inward direction to that content. Regarding the other inline matches, I'd like to point out a different case:
this "`quote with *strong* text`" is odd
this *"`strong quote`"* is just fine
I believe it would be better to have a new default highlight on the quoted string, which is still overridden by the other inline styles. What do you think?
Same case with emphasis and strong:
the *foo _bar_* is here.
the *foo b__ar__* is here.
the _foo b**ar**_ is here.
the _foo *bar*_ is here. Strange behaviour*
the _foo *bar* bar_ is here.
Point taken. This relates to the way in which inline nesting is handled in general. Then that can be directed to a separate issue, and this PR can be merged. 👍
I opened the issue #131
Description
Quotation Marks and Apostrophes: http://asciidoctor.org/docs/user-manual/#curved
Syntax example
Screenshots