asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

Migrate autocompletion to the grammar package. #133

Closed ldez closed 8 years ago

ldez commented 8 years ago

Migrate autocompletion to the grammar package.

nicorikken commented 8 years ago

The roadmap I envision:

  1. language-asciidoc copy autocompletion over and release
  2. language-asciidoc copy outstanding autocompletion issues over
  3. asciidoc-preview remove autocompletion support and release
  4. language-asciidoc convert to new autocompletion API version
  5. language-asciidoc address currently outstanding autocompletion issues (like scope)
ldez commented 8 years ago

and merge https://github.com/asciidoctor/atom-asciidoc-preview/pull/138 before all

ldez commented 8 years ago

language-asciidoc copy outstanding autocompletion issues over

Not needed I have already fixed all issues :wink:

Waiting for the asciidoc-preview release :smile_cat:

ldez commented 8 years ago

All it's done now! :tada:

mojavelinux commented 8 years ago

Amazing work!

nicorikken commented 8 years ago

In hindsight I'm glad we moved the autocomplete off to a separate package. Nice work.