chore: continuous delivery

asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.

https://atom.io/packages/language-asciidoc

MIT License

42 stars 20 forks source link

chore: continuous delivery #136

Closed ldez closed 8 years ago

ldez commented 8 years ago

@mojavelinux

Edit publish.sh:

USER_EMAIL: use to Git author
USER_NAME : use to Git author
$encrypted_key: rename this variable
$encrypted_iv: rename this variable

In Travis CI UI define:

ATOM_ACCESS_TOKEN with the Atom token

nicorikken commented 8 years ago

Does this imply that every merged PR is released as a new version? Because that does require complete PR's, which we just recently solved using the WIP and ready labels. Code looks good, I assume you did the right thing here. @mojavelinux can you make the final call on this one?

ldez commented 8 years ago

@nicorikken you are right: every merged PR is released as a new patch version by default.

I added documentation :wink:

ldez commented 8 years ago

The publishing system works when a commit is pushed on master. The publishing system does not publish if you publish manually (git tag detection).

nicorikken commented 8 years ago

I am new to Travis' concept of environment variables, but going from the documentation on Travis does a merge now requires a change in the .travis.yml file to set the type of release (major/minor/patch)?

ldez commented 8 years ago

:smile_cat: wrong section in the page, see https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

ldez commented 8 years ago

No changes in the .travis.yml file required for nothing. We never change this file. We simply use an UI, see https://travis-ci.org/asciidoctor/atom-language-asciidoc/settings

ldez commented 8 years ago

I added the web UI url to the documentation.

mojavelinux commented 8 years ago

I'll give it a shot and let you know if I run into any problems.

mojavelinux commented 8 years ago

@ldez Can you add asciidoctor-docbot to the package on atom.io? I just setup the account there.

ldez commented 8 years ago

@mojavelinux I don't understand. You have created an account on Atom.io for the asciidoctor-docbot ? If you have doing this, you have an Atom token.

ldez commented 8 years ago

For authorize the bot to publish, you must give it write access to this repository.

mojavelinux commented 8 years ago

Oh, I get it. I thought atom.io itself had to grant permissions. I didn't realize it was linked to GitHub auth.

mojavelinux commented 8 years ago

Am I correct that the RSA key should have no passphrase?

ldez commented 8 years ago

yes

mojavelinux commented 8 years ago

I sent a PR to your branch with the encrypted key and related configuration. I also added the Atom token to the build via the Travis CI web UI. I think we're good to go.

Do I need to keep the unencrypted RSA secret key?

mojavelinux commented 8 years ago

I guess merging this pull request is the moment of truth!

ldez commented 8 years ago

not needed.

And yes !!!!!!!! :tada:

ldez commented 8 years ago

AppVeyor is slow, very very slow...