asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

Don't uniformly colorize content of open block #154

Closed mojavelinux closed 8 years ago

mojavelinux commented 8 years ago

Description

The open block is often used to group other block-level AsciiDoc content. (It's most frequently used to attach arbitrary block-level content to a list item). As such, the content of the open block should be highlighted as AsciiDoc. Currently, the content of an open block is uniformly colorized (like a literal block) and there is no indication of syntax inside its boundaries. We can still highlight the delimiters (aka fences).

Screenshots

open-block

Syntax example

Using Bundler::
+
--
Add the `jekyll-asciidoc` plugin gem to your [path]_Gemfile_:

[source,ruby]
----
group :jekyll_plugins do
  gem 'jekyll-asciidoc'
end
----

Then, run the Bundler command to install it:

 $ bundle install
--
ldez commented 8 years ago

It's not colorized like a literal block but like a raw code block.

ldez commented 8 years ago

Solution A: capture du 2016-06-08 08-01-53

Solution B: capture du 2016-06-08 08-02-14

@mojavelinux What do you prefer?

mojavelinux commented 8 years ago

It's not colorized like a literal block but like a raw code block.

Yes, that's what I meant.

I like solution A. The reason I say that is that an open block is merely a grouping block (like a div, really). So we should only put a lasso around it rather than imply that it is some sort of semantic type via color.

ldez commented 8 years ago

Now, I better understand the meaning of this block