Add grammar for general inline macro - Githubissues

asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.

https://atom.io/packages/language-asciidoc

MIT License

42 stars 20 forks source link

Add grammar for general inline macro #162

Open ProgramFan opened 7 years ago

ProgramFan commented 7 years ago

Add general inline macro grammar so that custom inline macros can be highlighted.

For example: cite:[XXX] can be highlighted as in the following screenshot:

2016-09-17 9 52 05

mojavelinux commented 7 years ago

This is important for promoting the idea that extensions are a natural part of the AsciiDoc language.

Is the intent to style custom macros differently than built-in macros? I can see the logic to that. If not, all inline macros (including links) follow the same pattern, so it might be more efficient just to capture them all at once.

ProgramFan commented 7 years ago

Sorry for the mess of commit history. But the diff shall be clean. Would someone review it? Thanks.

ldez commented 7 years ago

Please rebase your branch. Thanks.

ProgramFan commented 7 years ago

Done. @ldez

ldez commented 7 years ago

I need to fix #170 before review it.

ProgramFan commented 7 years ago

OK.

ldez commented 7 years ago

Can you rebase once again, thanks.

ProgramFan commented 7 years ago

Done.