search

asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

Do not attempt to match newline characters #185

Closed 50Wliu closed 6 years ago

50Wliu commented 6 years ago

Description

This PR removes the [\\r\\n]+ requirement present in some end patterns. This regex wasn't really doing anything important in the first place (all it was contributing was a zero-width match at the end of the line). In addition, due to atom/first-mate#100, newlines are no longer added to the last line of the file, meaning that rules containing [\\r\\n]+ would fail to match on the last line. Therefore, this change is simply a backwards-compatible change to ensure that language-asciidoc continues working as before on Atom 1.22+.

I hope I did the whole grammar generation correctly!

/cc @Ingramz

Refs atom/atom#15729

ldez commented 6 years ago

@50Wliu Thanks 👍

The grammar generation is right.

I don't see any regressions.