search

asciidoctor / atom-language-asciidoc

⚛ AsciiDoc language package for the Atom editor.
https://atom.io/packages/language-asciidoc
MIT License
42 stars 20 forks source link

Heading style #88

Closed ldez closed 8 years ago

ldez commented 8 years ago

The recent changes breaks the heading style with some theme.

Currently (dev mode): capture du 2016-05-07 16-45-56

With my changes: capture du 2016-05-07 16-46-26

I have try with several themes.

nicorikken commented 8 years ago

I just noticed the same thing when switching themes. Good catch, good fix

nicorikken commented 8 years ago

You didn't refresh or commit your generate language, that's why your tests succeed 😉

ldez commented 8 years ago

mistake !!!!

ldez commented 8 years ago

Fixed :disappointed_relieved:

nicorikken commented 8 years ago

Almost... 😄

ldez commented 8 years ago

really fixed :cold_sweat:

ldez commented 8 years ago

Note I use .toEqualJson instead of .toEqual for a better tests failure report

ldez commented 8 years ago

I have added a small comment documentation about the use of f with fdescribe (focused describe) or fit (focused it)

nicorikken commented 8 years ago

Nice, so I learned something new today. Good PR, merge!