asciidoctor / brackets-asciidoc-preview

Live Preview of AsciiDoc for Adobe Brackets
MIT License
51 stars 16 forks source link

Merge effort with the PlantUML extension #41

Open ggrossetie opened 5 years ago

ggrossetie commented 5 years ago

I can see that you are using an extension to render PlantUML diagrams. I think it would be great to merge our efforts in https://github.com/eshepelyuk/asciidoctor-plantuml.js

The main advantage is that the extension can be reused in many editor. For instance I'm using the PlantUML extension in the browser extension.

You could for instance contribute the missing "substitution feature" https://github.com/eshepelyuk/asciidoctor-plantuml.js/issues/38

What do you think ?

mojavelinux commented 5 years ago

Keep in mind there's also the initiative to add a web-based API in asciidoctor-diagram, which would open up all of it's capabilities to Asciidoctor.js. See https://github.com/asciidoctor/asciidoctor-diagram/issues/183.

nerk commented 5 years ago

@Mogztter I was already looking at that code to figure out if I could use it. It also tought me that there is an API to declare positional attributes. 👍

PlantUML is being invoked from within a JavaScript worker by the Brackets extension. I might be wrong, but I think asciidoctor-plantuml.js will have currently problems with that. For example, modules and require() won't work. That prevented me to directly use that code. But I fully agree, it would be great if this could be used.

ggrossetie commented 5 years ago

@nerk The extension also produce a "browserified" version so it can be used in a browser environment. I'm not familiar with the brackets JavaScript environment but you should try the browser version. If it's not working we can adapt the code (much like Asciidoctor.js) to make it work in a bracket environment 😉