asciidoctor / brackets-asciidoc-preview

Live Preview of AsciiDoc for Adobe Brackets
MIT License
51 stars 16 forks source link

Use asciidoctor-default.css theme #9

Closed leif81 closed 10 years ago

leif81 commented 10 years ago

I've grown quite comfortable seeing the default Asciidoctor HTML theme -- the one that's also used by the asciidoctor-chrome-extension. It would be really nice if the Brackets AsciiDoc preview used this theme by default or gave it as an option.

https://github.com/asciidoctor/asciidoctor/blob/master/data/stylesheets/asciidoctor-default.css

nerk commented 10 years ago

Sure, this can be added along with some other additional themes. The reason why I avoided it initially was that this theme uses lots of vertical space between elements. IMHO, this does not really go well with the preview panel at the bottom. I was already planning to provide a very compact theme for that reason.

The best solution would be if Brackets provided a clean way to have a side-by-side view of the editor and the preview panel. Right now, it seems to be possible only by modifying the editor layout from the extension, which is discouraged by the Brackets developers. I may be wrong, though.

leif81 commented 10 years ago

Great, thankyou @nerk . :+1:

Aside from personally liking that default theme, I think it's good branding for Asciidoctor to have a consistent look & feel across all the editors. I noticed the Atom screenshots are using this theme too:

https://raw.githubusercontent.com/asciidoctor/atom-asciidoc-preview/master/screenshot.jpg

mojavelinux commented 10 years ago

With a few changes to the settings in the Asciidoctor stylesheet factory theme config, it's possible to produce a more compact them. The spacing is optimized for readability, something I personally think Bootstrap doesn't get right. Defaulting to the Asciidoctor theme would be good for consistency, as @leif81 mentions, though I am glad that the extension gives authors the option to choose a theme that works best for them.

nerk commented 10 years ago

Asciidoctor theme now used as the default. Added 'asciidoctor-compact' and 'github' themes.

leif81 commented 10 years ago

:+1: Fantastic! I'm impatiently checking Brackets for the 1.0.6 update :)