asciidoctor / docbookrx

(An early version of) a DocBook to AsciiDoc converter written in Ruby.
MIT License
22 stars 49 forks source link

Fix typo in installation instructions #20

Closed vogella closed 8 years ago

vogella commented 8 years ago

I think the current "gem install bundler" is a typo

mojavelinux commented 8 years ago

Oddly enough, the gem name is "bundler" but the command name is "bundle". See https://rubygems.org/gems/bundle

vogella commented 8 years ago

I wounder now what I have installed with "gem install bundle" ;-)

Thanks for the feedback.

vogella commented 8 years ago

FYI "gem install bundle" seems to work fine and might be less confusing for none ruby people like me. Here is my installation output:

vogella@Frodo:~/git/docbookrx$ sudo gem install bundle [sudo] password for vogella: Fetching: bundler-1.11.2.gem (100%) Successfully installed bundler-1.11.2 Fetching: bundle-0.0.1.gem (100%) Successfully installed bundle-0.0.1 Parsing documentation for bundle-0.0.1 Installing ri documentation for bundle-0.0.1 Parsing documentation for bundler-1.11.2 Installing ri documentation for bundler-1.11.2 Done installing documentation for bundle, bundler after 4 seconds 2 gems installed

vogella commented 8 years ago

Please close PR if you prefer the current statement

mojavelinux commented 8 years ago

We can add a note, but we shouldn't rely on the gem being there forever.

mojavelinux commented 8 years ago

If you'd like, you change the sentence to:

Then, use the bundle command (which is provided by the bundler gem) to install the project dependencies:

mojavelinux commented 8 years ago

That way we acknowledge the difference.

vogella commented 8 years ago

PR updated with your proposal.

mojavelinux commented 8 years ago

Excellent! Thanks!

vogella commented 8 years ago

Thanks for your patience

mojavelinux commented 8 years ago

Thank you for the suggestion. It's important to know how this information is perceived so that we can put the reader on a path to success!