Closed junaruga closed 8 years ago
@mojavelinux This is more your thing. Any objections?
I agree, but I would like to see an update to the README. I sent an update to this PR.
I definitely want to encourage devs to install gems into the project because I'm growing weary of explaining to people how to isolate gems from the system. The instructions in my update to the README now make this clear. Once that is merged into this PR, then I'll be ready to move forward with this PR.
Note that I removed the env variable from Rakefile. I don't think that's needed.
@mojavelinux Thanks! I merged its update!
Thanks! Let's proceed!
@mojavelinux this pull-request has 3 commits. Do you like me to squash these 3 commits to 1 commit?
I might find one mistake in the document.
Before
$ bundle --path=.bundle/rubygems
After
$ bundle install --path=.bundle/rubygems
Ah $ bundle --path=.bundle/rubygems
was actually same with $ bundle install --path=.bundle/rubygems
.
@junaruga Please do -- the commits all relate to the same thing, so that would be better.
Thanks!
Exactly, "install" is the default command.
No need to squash. @mrietveld can do that using the Merge button on GitHub. Makes life simpler :)
@mrietveld, I find that using the Merge (+ squash) button produces better results because it maintains the authors accurately.
@mojavelinux Ohh.. of course! Thanks, Dan.
"the Merge (+ squash) button"?! Cool!
It looks not merged to master branch yet. Is there something I have to do?
I think we should not need .bundle/config file to git repository. Because it is modified file, depending on user's environment. And its situation is not good for the development. For example, it prevents user to do "git rebase".
Before modification
I can understand why you added the file, because of compiling nokogiri with system library. And we can set a environment variable to get same result.
After modification