search

asciidoctor / docbookrx

(An early version of) a DocBook to AsciiDoc converter written in Ruby.
MIT License
22 stars 49 forks source link

I have a ton of fixes - how to submit ? #66

Open kkaempf opened 5 years ago

kkaempf commented 5 years ago

Last year, SUSE started to convert its docbook/xml documentation to asciidoc. I have a ton of fixes for docbookrx to make that happen.

Given that docbookrx hasn't seen an update for almost a year, I wonder if this project is still active and would be interested. I'd rather not open PRs for each of these fixes :wink:

Any suggestions on how to proceed ?

mojavelinux commented 5 years ago

I appreciate your offer. The only dilemma I face is that I also have a ton of pending fixes that I just haven't had a chance to submit. In fact, I rearchitected the whole program to work in a much more logical way. But I've been so busy I haven't gotten around to pushing up the changes.

Given that I don't plan to keep much of the code that's there today anyway, what I might have you do is submit the changes and get them merged. That way, I can examine the code for any new requirements I might have missed. Then, I can incorporate those requirements into the new architecture. Ideally, we should end up with a result that combines your improvements with mine.

The most important aspect are the tests. That's how we know that we can rework the internals, but still get the same result. And if we do get a different result, it gives us something to discuss.

DaanDeMeyer commented 4 years ago

@mojavelinux Any chance you might still push those fixes?

mojavelinux commented 3 years ago

I just don't have time to work on this project right now, so I'm looking for a new maintainer. While I regret that I do still have a lot of changes to submit, I can't see myself finding the time to do it...so it will just need to proceed without those changes (and perhaps it will turn out better anyway).

mojavelinux commented 11 months ago

At this point, if you want to submit fixes, I would accept them if they have tests. I now realize that the changes I was going to make wouldn't conflict anyway (as they are more structural in nature).