search

asciidoctor / docbookrx

(An early version of) a DocBook to AsciiDoc converter written in Ruby.
MIT License
22 stars 49 forks source link

fix "cannot load such file -- docbookrx (LoadError)" #73

Closed saper closed 11 months ago

saper commented 1 year ago

Make sure all files required are installed via gem even if git executable is present.

IO.popen() will not raise an exception if the command runs and fails with an error message. An extra check is needed for the exit code.

Inspired by: https://stackoverflow.com/a/30940226 Downstream: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272554

mojavelinux commented 11 months ago

Thanks for alerting me to this problem. Superseded by 5ed88b6a4031558023823448c172d31bf564ebc0. There's portable logic that we prefer to use for projects in this organization, which I have applied.

saper commented 11 months ago

Thank you for checking this out! Great to have it fixed!