search

asciidoctor / docgist

Render AsciiDoc documents from Gists, GitHub, DropBox and other remote sources in the browser.
http://gist.asciidoctor.org
57 stars 79 forks source link

Fixing imagesdir support; adding prettify support; updating libraries. #15

Closed nawroth closed 9 years ago

nawroth commented 9 years ago

Fixes mimetyoe of SVG images by using rawgit.com. Fixes #14 (see the discussion there)

mojavelinux commented 9 years ago

Nice job!

mojavelinux commented 9 years ago

Fixes mimetyoe of SVG images by using rawgit.com.

I wonder if this problem will be solved by the following change: https://github.com/asciidoctor/asciidoctor/issues/1301

Btw, it seems that caching isn't an issue if you use rawgit.com, but would be an issue if you use cdn.rawgit.com.

“New changes you push to GitHub will be reflected within minutes.“ (when using rawgit.com)

nawroth commented 9 years ago

It seems like the mimetype sent by the server takes precedence, so that change wouldn't make any difference.

Regarding rawgit, they don't want production systems to use the non-cdn URLs. So in case a page gets really many hits, that might be a problem. Maybe we should take care of that when we actually have that problem though.

mojavelinux commented 9 years ago

It seems like the mimetype sent by the server takes precedence, so that change wouldn't make any difference.

Thanks for the clarification.

Maybe we should take care of that when we actually have that problem though.

Agreed. They are probably talking about Hacker News front-page order of hits...so unless people are craving a page of documentation that bad, I think we'll probably be okay with rawgit.com :)

nawroth commented 9 years ago

We had a graphgist on the HN front page, generating tons of hits!

mojavelinux commented 9 years ago

We had a graphgist on the HN front page, generating tons of hits!

:open_mouth: