asciidoctor / docker-asciidoctor

:ship: A Docker image for using the Asciidoctor toolchain to process AsciiDoc content
https://hub.docker.com/r/asciidoctor/docker-asciidoctor/
Other
324 stars 149 forks source link

Bump Asciidoctor-Diagram version 2.2.6 #345

Closed asciidoctor-updateclibot[bot] closed 1 year ago

asciidoctor-updateclibot[bot] commented 1 year ago

Bump Asciidoctor-Diagram version 2.2.6

Report

Source:
    ✔ [latestVersion] Get the latest Asciidoctor-Diagram version from latest git tag (no GitHub release)(gittag)

Condition:
    ✔ [checkIfGemIsPublished] Check if the Gem is published(shell)
    ✔ [testDockerfileArgVersion] Does the Dockerfile have an ARG instruction which key is asciidoctor_diagram_version?(dockerfile)
    ✔ [testVersionInReadme] Does the README.adoc have a variable ASCIIDOCTOR_DIAGRAM_VERSION(file)
    ✔ [testVersionInTestHarness] Does the test harness have variable ASCIIDOCTOR_DIAGRAM_VERSION(file)

Target:
    ✔ [updateDockerfile] Update the value of ARG asciidoctor_diagram_version in the Dockerfile(dockerfile)
    ✔ [updateReadme] Update the key ASCIIDOCTOR_DIAGRAM_VERSION in the README.adoc file(file)
    ✔ [updateTestHarness] Update the key ASCIIDOCTOR_DIAGRAM_VERSION in the test harness(file)

Changelog

Click to expand ```` ````

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

dduportal commented 1 year ago

Currently fails the test phase with the following error:

#   `[ "$(echo ${output} | grep -c -i error)" -eq 0 ]' failed
# -- Output of command:
# Exception in thread "main" java.util.ServiceConfigurationError: org.asciidoctor.diagram.DiagramGenerator: Provider org.asciidoctor.diagram.plantuml.PlantUML could not be instantiated
#   at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
#   at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
#   at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
#   at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
#   at org.asciidoctor.diagram.AbstractCommandServer.loadGenerators(AbstractCommandServer.java:31)
#   at org.asciidoctor.diagram.AbstractCommandServer.<clinit>(AbstractCommandServer.java:14)
# Caused by: java.lang.NoClassDefFoundError: net/sourceforge/plantuml/cucadiagram/dot/GraphvizUtils
#   at org.asciidoctor.diagram.plantuml.PlantUML.<clinit>(PlantUML.java:38)
#   at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
#   at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
#   at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
#   at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
#   at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
#   at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:789)
#   ... 4 more
# Caused by: java.lang.ClassNotFoundException: net.sourceforge.plantuml.cucadiagram.dot.GraphvizUtils
#   at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
#   at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
#   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
#   ... 11 more
# asciidoctor: ERROR: sample-with-diagram.adoc: line 13: Failed to generate image: Error processing request {:url=>"/plantumlpreprocessor", :body=>"@startuml\nclass Sample {\n}\n@enduml", :headers=>{"X-PlantUML-Basedir"=>"/documents/fixtures"}}
# Encoding of input is UTF-8
# asciidoctor: ERROR: sample-with-diagram.adoc: line 24: Failed to generate image: Broken pipe
# asciidoctor: ERROR: activity_diagram.txt: line 0: Failed to generate image: Broken pipe
dduportal commented 1 year ago
dduportal commented 1 year ago

Testing with: https://rubygems.org/gems/asciidoctor-diagram/versions/2.2.6

dduportal commented 1 year ago

Confirmed that 2.2.6 fixes the issue. Pinging @pepijnve for information (the git tag 2.2.6 is missing on asciidoctor-diagram despite the changelog and rubygem published with this version).

pepijnve commented 1 year ago

Oops. I really need to automate my release stuff further. I keep on forgetting to push the release tag out to GitHub.

FYI, the 2.2.5 failure is due to me building a 1.2023.x version of the PlantUML wrapper gem and that being incompatible with the java glue code in the diagram gem. 2.2.6 fixes that.