Closed asciidoctor-updateclibot[bot] closed 6 months ago
Better skip 2.0.0, there's 2.0.1 out already with important regression bugfix.
See #410 instead
Whoops, it looks like we were working simultaneously on fixing this...
Whoops, it looks like we were working simultaneously on fixing this...
ah ah ;)
Many many thanks for your help and your PR!
I hesitated to install missing linux-headers but went full "add native alpine ffi" package.
There is a tradeoff between faster build (with native ruby-ffi
package) and additional size of the resulting image (as ffi
might not fully be required).
What are your thoughts?
I don't have strong opinion here, I am not a real Ruby dev :D Do whatever you feel more appropriate.
I dunno, maybe asciidoctor-epub3 itself was supposed to have dependency on Well, no. We have a transitive dependency on ruby-ffi
...ffi
and that is supposed to bring in whatever it needs.
I'm surprised that linux-headers is now a dependency at all, will try to get rid of it in the future.
I don't have strong opinion here, I am not a real Ruby dev :D Do whatever you feel more appropriate. I dunno, maybe asciidoctor-epub3 itself was supposed to have dependency on ruby-fi...
I'm surprised that linux-headers is now a dependency at all, will try to get rid of it in the future.
Thanks for your answer!
linux-dependency
is only a dependency to allow ruby to build ffi
during the installation process of asciidoctor-epub3. But it looks like installing ruby-ffi
native package allow to avoid this requirement.
I'll proceed to merge this PR. If it does not feel right, no problem to revert and reopen #410 .
Many thanks for the help @slonopotamus!
@slonopotamus I tried to make you a co-author of this PR, but did not work. I'll add you in the changelog though. Thanks for the help!
Bump Asciidoctor-Epub3 version
Update the key ASCIIDOCTOR_EPUB3_VERSION in the test harness
1 file(s) updated with "ASCIIDOCTOR_EPUB3_VERSION=2.0.0": * tests/asciidoctor.bats
2.0.0
2.0.1
Update the key ASCIIDOCTOR_EPUB3_VERSION in the README.adoc file
1 file(s) updated with ":ASCIIDOCTOR_EPUB3_VERSION: 2.0.0": * README.adoc
2.0.0
2.0.1
Update the value of ARG asciidoctor_epub3_version in the Dockerfile
changed lines [86] of file "/tmp/updatecli/github/asciidoctor/docker-asciidoctor/Dockerfile"
2.0.0
2.0.1
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!