search

asciidoctor / docker-asciidoctor

:ship: A Docker image for using the Asciidoctor toolchain to process AsciiDoc content
https://hub.docker.com/r/asciidoctor/docker-asciidoctor/
Other
321 stars 151 forks source link

Bump Asciidoctor version to 2.0.22 #432

Closed asciidoctor-updateclibot[bot] closed 3 months ago

asciidoctor-updateclibot[bot] commented 4 months ago

Bump Asciidoctor version

Update the value of ARG asciidoctor_version in the Dockerfile

changed lines [16] of file "/tmp/updatecli/github/asciidoctor/docker-asciidoctor/Dockerfile"

2.0.22 
Release published on the 2024-03-08 08:02:44 +0000 UTC at the url https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.22

This is a patch release in the 2.0.x release line to further compatibility with Ruby 3.3.

The most critical fix in this release is to remove use of the base64 library since it will no longer being provided as part of the Ruby language starting with Ruby 3.4. When using Ruby 3.3, users would see a warning if this library is used, which happens when the data-uri attribute is set. The functionality has been replaced with a lower-level method on the String object (String#pack), which the base64 library delegates to anyway.

This release also sets the cloaked-context attribute on a source block that is defined using either a styled paragraph or a literal or fenced code structural container. This matches the functionality used for custom block extensions (when the source context does not match the final parsed context).

## Distribution

- [RubyGem (asciidoctor)](https://rubygems.org/gems/asciidoctor)

Asciidoctor is also packaged for [Fedora](https://apps.fedoraproject.org/packages/rubygem-asciidoctor), [Debian](https://packages.debian.org/sid/asciidoctor), [Ubuntu](https://packages.ubuntu.com/search?keywords=asciidoctor), [Alpine Linux](https://pkgs.alpinelinux.org/packages?name=asciidoctor), [OpenSUSE](https://software.opensuse.org/package/rubygem-asciidoctor), and [Homebrew](https://formulae.brew.sh/formula/asciidoctor). You can use the system's package manager to install the package named **asciidoctor**.

## Changelog

### Improvements

* Set `cloaked-context` attribute on source block when context is not `:listing` (#4556)

### Compliance

* Remove use of base64 library to prevent warning in Ruby >= 3.3 (#4561)

## Release meta

Released on: 2024-03-08
Released by: @mojavelinux
Release beer: Turbo Laser by Resolute Brewing Company

Logs: [resolved issues](https://github.com/asciidoctor/asciidoctor/issues?q=is%3Aissue+label%3Av2.0.22+is%3Aclosed) | [source diff](https://github.com/asciidoctor/asciidoctor/compare/v2.0.21...v2.0.22) | [gem diff](https://my.diffend.io/gems/asciidoctor/v2.0.21/v2.0.22)

## Credits

A very special thanks to all the **awesome** [supporters of the Asciidoctor OpenCollective campaign](https://opencollective.com/asciidoctor), who provide critical funding for the ongoing development of this project.
Update the key ASCIIDOCTOR_VERSION in the test harness

1 file(s) updated with "ASCIIDOCTOR_VERSION=2.0.22": * tests/asciidoctor.bats

2.0.22 
Release published on the 2024-03-08 08:02:44 +0000 UTC at the url https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.22

This is a patch release in the 2.0.x release line to further compatibility with Ruby 3.3.

The most critical fix in this release is to remove use of the base64 library since it will no longer being provided as part of the Ruby language starting with Ruby 3.4. When using Ruby 3.3, users would see a warning if this library is used, which happens when the data-uri attribute is set. The functionality has been replaced with a lower-level method on the String object (String#pack), which the base64 library delegates to anyway.

This release also sets the cloaked-context attribute on a source block that is defined using either a styled paragraph or a literal or fenced code structural container. This matches the functionality used for custom block extensions (when the source context does not match the final parsed context).

## Distribution

- [RubyGem (asciidoctor)](https://rubygems.org/gems/asciidoctor)

Asciidoctor is also packaged for [Fedora](https://apps.fedoraproject.org/packages/rubygem-asciidoctor), [Debian](https://packages.debian.org/sid/asciidoctor), [Ubuntu](https://packages.ubuntu.com/search?keywords=asciidoctor), [Alpine Linux](https://pkgs.alpinelinux.org/packages?name=asciidoctor), [OpenSUSE](https://software.opensuse.org/package/rubygem-asciidoctor), and [Homebrew](https://formulae.brew.sh/formula/asciidoctor). You can use the system's package manager to install the package named **asciidoctor**.

## Changelog

### Improvements

* Set `cloaked-context` attribute on source block when context is not `:listing` (#4556)

### Compliance

* Remove use of base64 library to prevent warning in Ruby >= 3.3 (#4561)

## Release meta

Released on: 2024-03-08
Released by: @mojavelinux
Release beer: Turbo Laser by Resolute Brewing Company

Logs: [resolved issues](https://github.com/asciidoctor/asciidoctor/issues?q=is%3Aissue+label%3Av2.0.22+is%3Aclosed) | [source diff](https://github.com/asciidoctor/asciidoctor/compare/v2.0.21...v2.0.22) | [gem diff](https://my.diffend.io/gems/asciidoctor/v2.0.21/v2.0.22)

## Credits

A very special thanks to all the **awesome** [supporters of the Asciidoctor OpenCollective campaign](https://opencollective.com/asciidoctor), who provide critical funding for the ongoing development of this project.
Update the key ASCIIDOCTOR_VERSION in the README.adoc file

1 file(s) updated with ":ASCIIDOCTOR_VERSION: 2.0.22": * README.adoc

2.0.22 
Release published on the 2024-03-08 08:02:44 +0000 UTC at the url https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.22

This is a patch release in the 2.0.x release line to further compatibility with Ruby 3.3.

The most critical fix in this release is to remove use of the base64 library since it will no longer being provided as part of the Ruby language starting with Ruby 3.4. When using Ruby 3.3, users would see a warning if this library is used, which happens when the data-uri attribute is set. The functionality has been replaced with a lower-level method on the String object (String#pack), which the base64 library delegates to anyway.

This release also sets the cloaked-context attribute on a source block that is defined using either a styled paragraph or a literal or fenced code structural container. This matches the functionality used for custom block extensions (when the source context does not match the final parsed context).

## Distribution

- [RubyGem (asciidoctor)](https://rubygems.org/gems/asciidoctor)

Asciidoctor is also packaged for [Fedora](https://apps.fedoraproject.org/packages/rubygem-asciidoctor), [Debian](https://packages.debian.org/sid/asciidoctor), [Ubuntu](https://packages.ubuntu.com/search?keywords=asciidoctor), [Alpine Linux](https://pkgs.alpinelinux.org/packages?name=asciidoctor), [OpenSUSE](https://software.opensuse.org/package/rubygem-asciidoctor), and [Homebrew](https://formulae.brew.sh/formula/asciidoctor). You can use the system's package manager to install the package named **asciidoctor**.

## Changelog

### Improvements

* Set `cloaked-context` attribute on source block when context is not `:listing` (#4556)

### Compliance

* Remove use of base64 library to prevent warning in Ruby >= 3.3 (#4561)

## Release meta

Released on: 2024-03-08
Released by: @mojavelinux
Release beer: Turbo Laser by Resolute Brewing Company

Logs: [resolved issues](https://github.com/asciidoctor/asciidoctor/issues?q=is%3Aissue+label%3Av2.0.22+is%3Aclosed) | [source diff](https://github.com/asciidoctor/asciidoctor/compare/v2.0.21...v2.0.22) | [gem diff](https://my.diffend.io/gems/asciidoctor/v2.0.21/v2.0.22)

## Credits

A very special thanks to all the **awesome** [supporters of the Asciidoctor OpenCollective campaign](https://opencollective.com/asciidoctor), who provide critical funding for the ongoing development of this project.
GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

dduportal commented 3 months ago

I can reproduce locally using the 1.67.0 image (I have a M2 mac so I need to emulate linux/amd64):

$ docker run --user=root -ti -v $(pwd)/tests:/documents --entrypoint=bash --platform=linux/amd64 asciidoctor/docker-asciidoctor:1.67.0   
8215fe7092d9:/documents# asciidoctor -D /documents/tmp -r asciidoctor-kroki \
      /documents/fixtures/sample-with-diagram.adoc
8215fe7092d9:/documents# echo $?
0

8215fe7092d9:/documents# gem install --no-document asciidoctor:2.0.22
Fetching asciidoctor-2.0.22.gem
Successfully installed asciidoctor-2.0.22
1 gem installed

A new release of RubyGems is available: 3.4.10 → 3.5.6!
Run `gem update --system 3.5.6` to update your installation.

8215fe7092d9:/documents# asciidoctor -D /documents/tmp -r asciidoctor-kroki       /documents/fixtures/sample-with-diagram.adoc
asciidoctor: FAILED: /documents/fixtures/sample-with-diagram.adoc: Failed to load AsciiDoc document - uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64
  Use --trace to show backtrace
dduportal commented 3 months ago

Exact error seems to be:

uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64

(but it could be a qemu error in my case)

mojavelinux commented 3 months ago

Asciidoctor core no longer loads Base64. At this point, it's a burned library. It should no longer be used by any project in Asciidoctor. The low-level String#pack and String#unpack1 methods should be used instead.

See https://github.com/asciidoctor/asciidoctor/issues/4561 and https://twitter.com/mojavelinux/status/1765870415753183732 for context.

dduportal commented 3 months ago

I'm not sure why this PR has been merged as I did no further action since Dan's comment above.

However GitHub indicates I've merged it: I believe I've left the auto-merge feature and the checks API said "green" at a moment on time.

However #437 is open with the same change which, again, unexpected : I believe GitHub actions had issue recently. Let's continue in #437