Closed asciidoctor-updateclibot[bot] closed 3 months ago
As commented in #432 which has been superseded by the current PR:
This new version makes the following test to fail:
not ok 23 We can generate an HTML document with a diagram with asciidoctor-kroki as backend # (in test file tests/asciidoctor.bats, line 170) # `[ "${status}" -eq 0 ]' failed
Exact error seems to be (on my reproduction case involving qemu on my mac M2):
uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64
(but it could be a qemu-related error) => to be checked in a full
linux/amd64
Linux VM.
Followed by @mojavelinux 's comment:
Asciidoctor core no longer loads Base64. At this point, it's a burned library. It should no longer be used by any project in Asciidoctor. The low-level String#pack and String#unpack1 methods should be used instead.
See https://github.com/asciidoctor/asciidoctor/issues/4561 and https://twitter.com/mojavelinux/status/1765870415753183732 for context.
Analysis in progress (thanks Dan!)
Opened an issue pointing at the code to change: https://github.com/asciidoctor/asciidoctor-kroki/issues/444
@mojavelinux what is your point of view on how to act now:
asciidoctor
2.0.22?
Bump Asciidoctor version
Update the key ASCIIDOCTOR_VERSION in the test harness
1 file(s) updated with "ASCIIDOCTOR_VERSION=2.0.22": * tests/asciidoctor.bats
2.0.22
Update the key ASCIIDOCTOR_VERSION in the README.adoc file
1 file(s) updated with ":ASCIIDOCTOR_VERSION: 2.0.22": * README.adoc
2.0.22
Update the value of ARG asciidoctor_version in the Dockerfile
changed lines [16] of file "/tmp/updatecli/github/asciidoctor/docker-asciidoctor/Dockerfile"
2.0.22
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!