search

asciidoctor / docker-asciidoctor

:ship: A Docker image for using the Asciidoctor toolchain to process AsciiDoc content
https://hub.docker.com/r/asciidoctor/docker-asciidoctor/
Other
321 stars 151 forks source link

feature: add `barcode` extension #459

Closed jeromeag closed 6 days ago

jeromeag commented 1 week ago

Add barcode feature as described here: https://docs.asciidoctor.org/diagram-extension/latest/diagram_types/barcode/

jeromeag commented 1 week ago

Hi @dduportal, Thank you for your quick feedback !

Hi @jeromeag , many thanks for this feature. It looks good and legit!

Before approving it, there are a few steps left:

* Could you give us a size (approximatively) difference before and after the change (to evaluate the change impact)?

Here is the before/after results of command docker image ls after make build-load

Before:

$ docker image ls 
REPOSITORY    TAG       IMAGE ID       CREATED       SIZE
asciidoctor   latest    2de7ba181c26   4 hours ago   791MB
<none>        <none>    95010f29fbfd   4 days ago    47MB
<none>        <none>    794e485ffc6e   3 weeks ago   325MB

After:

REPOSITORY    TAG       IMAGE ID       CREATED          SIZE
asciidoctor   latest    c478415b410d   28 seconds ago   793MB
<none>        <none>    2de7ba181c26   4 hours ago      791MB
<none>        <none>    95010f29fbfd   4 days ago       47MB
<none>        <none>    794e485ffc6e   3 weeks ago      325MB
* Could you update your change to use fixed version to the 3 new Gems (following other examples) so it would be documented by the automation, and I could add the version tracking with `updatecli`?

Done !