asciidoctor / docs.asciidoctor.org

The Antora playbook project (i.e., site manifest) for the Asciidoctor documentation site.
https://docs.asciidoctor.org
MIT License
14 stars 18 forks source link

Publish asciidoctor-maven-plugin v3.0.0 #78

Closed abelsromero closed 7 months ago

abelsromero commented 8 months ago

Last step for v3.0.0 release.

@mojavelinux don't merge yet, I have a question. This gets published as soon as merged or is still nightly iirc?

mojavelinux commented 8 months ago

It gets published as soon as it's merged (Netlify watches the repository). The site also builds nightly (triggered by GitHub Actions).

You have the option of configuring the asciidoctor-maven-plugin repository to trigger a build when a docs change is made too. We do this for Asciidoctor PDF, for example. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v2.3.x/.github/workflows/deploy-docs.yml

abelsromero commented 8 months ago

Ready, feel free to merge, starting v3.0.0 release.

mojavelinux commented 7 months ago

Congrats!!!

abelsromero commented 7 months ago

@mojavelinux I saw the asciidoctor-maven-plugin commit with the extra fixes. Thanks! :bow:

mojavelinux commented 7 months ago

Yep, just did some quick tidying after I saw it published for the first time.

mojavelinux commented 7 months ago

I noticed that there are two pages with the same doctitle and navtitle. Could you differentiate them by updating the doctitle at least?

abelsromero commented 7 months ago

Thanks again, I'll have a look at those tomorrow.

abelsromero commented 7 months ago

I made the fixes, I only updated the titles, the nav makes sense to me since those are the respective guides for the main plugin and the site modules.

Regarding the automatic trigger, seems I need a token, can I ask you to add it to https://github.com/asciidoctor/asciidoctor-maven-plugin/settings/secrets/actions ? That way we keep things secure; we don't need to share it in other channels, and I won't be able to see it since GH does not allow to see them once set.

mojavelinux commented 7 months ago

Yep, I'll set it up for you.

mojavelinux commented 7 months ago

You should be set to go. Refer to https://github.com/asciidoctor/asciidoctor-pdf/blob/v2.3.x/.github/workflows/deploy-docs.yml for how to use it.

abelsromero commented 7 months ago

You are awesome! thanks