search

asciidoctor / gulp-asciidoctor

gulp-asciidoctor
https://www.npmjs.com/package/@asciidoctor/gulp-asciidoctor
14 stars 8 forks source link

resolves #16 add GitHub Actions CI #18

Closed ggrossetie closed 4 years ago

ggrossetie commented 4 years ago

resolves #16

henriette-einstein commented 4 years ago

I will include the nice icons for CI and npm in the file README.md in the branch with the changes for Asciidoctor 2.2.0

ggrossetie commented 4 years ago

Perfect, I can also add the CI badge in this pull request if you want.

henriette-einstein commented 4 years ago

There is no README.md in the release underlying this pull request. I think it does not make too much sense to add one here and then overwrite it later.

ggrossetie commented 4 years ago

There is no README.md in the release underlying this pull request. I think it does not make too much sense to add one here and then overwrite it later.

Ah you're right :grimacing: Let me know if you want to change something before merging.

henriette-einstein commented 4 years ago

Node 14.x is not in the list of node versions. Is it not supported?

ggrossetie commented 4 years ago

You are right, it should be 12 (current LTS) and 14 (latest stable). I will update it.

henriette-einstein commented 4 years ago

Perfect! You can merge the request now