search

asciidoctor / gulp-asciidoctor

gulp-asciidoctor
https://www.npmjs.com/package/@asciidoctor/gulp-asciidoctor
14 stars 8 forks source link

Changed the way options are handled #2

Closed AzazelN28 closed 9 years ago

AzazelN28 commented 9 years ago

Added "options = options || {}" to avoid "undefined " errors when you don't pass arguments to gulp-asciidoctor and changed some option names to be more correct (base_dir to baseDir and header_footer to headerFooter).

dongwq commented 9 years ago

I added some mocha test. arguments name should be kept consistent with asciidoctor.js ,so i choose base_dir and header_footer.

AzazelN28 commented 9 years ago

Yep. That's true. Could we maintain both naming options? What do you think?

dongwq commented 9 years ago

I think it's better to keep it as simple as possible., base_dir is ok ,baseDir is not needed. Though I am a javaer, like baseDir more.

dongwq commented 9 years ago

FYI, I've updated v 1.0.6 coming with more test cases, more readme.

AzazelN28 commented 9 years ago

Cool! updating