search

asciidoctor / jekyll-asciidoc-quickstart

A template project for creating AsciiDoc-based websites using Jekyll.
https://asciidoctor.github.io/jekyll-asciidoc-quickstart/
MIT License
124 stars 158 forks source link

Consolidate stylesheets #14

Open mojavelinux opened 8 years ago

mojavelinux commented 8 years ago

The default page layout should not be loading both the default Asciidoctor stylesheet (asciidoctor.css) and Foundation (foundation.css). The default Asciidoctor stylesheet already includes Foundation (and Normalizer), so this combination includes a tremendous number of redundant (and potentially conflicting) styles.

What needs to be done is to create a combined stylesheet that includes Foundation and just the parts of the Asciidoctor stylesheet that supplement Foundation. This is essentially the use case that https://github.com/asciidoctor/asciidoctor-stylesheet-factory/issues/18 is proposing to address.

The other approach is to simply start writing a new stylesheet for AsciiDoc components that includes only what is needed to style them within a Jekyll site. Admittedly, this is more time consuming, but will likely produce the most concise result in the end.

mojavelinux commented 8 years ago

I also think that the CodeRay and Font Awesome stylesheets should be loaded after the Asciidoctor stylesheet (in that order).

johncarl81 commented 8 years ago

Should we not include the foundation javascript as well?

mojavelinux commented 8 years ago

The Foundation JavaScript is only necessary for using one of the Foundation components. These are indicated with the "JS" label in the Foundation docs. (see http://foundation.zurb.com/sites/docs/) These aren't needed for the AsciiDoc content, but could be useful for other components on the screen.

johncarl81 commented 8 years ago

Looking at this issue and trying to remove the css... could you @mojavelinux create a stylesheet that would include both asciidoctor and foundation in a PR?

mojavelinux commented 8 years ago

We can't do that until https://github.com/asciidoctor/asciidoctor-stylesheet-factory/issues/18 is resolved (because that's the solution).

We should probably have a flag on that build that includes the whole Foundation stylesheet or just part of it so that you can either use Foundation minimally or a complete integration. I'll note that.

johncarl81 commented 8 years ago

Cool, I'll keep my eye on your progress :+1:

mojavelinux commented 8 years ago

Of course, we also need to upgrade to Foundation 6. Lots of progress ahead!

Chumper commented 8 years ago

:+1: for Foundation 6

johncarl81 commented 8 years ago

Any movement on all of this @mojavelinux?

mojavelinux commented 8 years ago

Yes, I'm starting to work with @Mogztter on the upgrade to Foundation 5, then Foundation 6, then get the build working to create a stylesheet for embeddable documents. See https://github.com/asciidoctor/asciidoctor.org/issues/564.