asciidoctor / jekyll-asciidoc-quickstart

A template project for creating AsciiDoc-based websites using Jekyll.
https://asciidoctor.github.io/jekyll-asciidoc-quickstart/
MIT License
119 stars 159 forks source link

Updated to Latest jekyll #16

Closed johncarl81 closed 8 years ago

johncarl81 commented 8 years ago

I believe this does the trick, WDYT @mojavelinux #15

mojavelinux commented 8 years ago

Do you think we should lock the versions, at least to the major versions?

johncarl81 commented 8 years ago

Although I'm a bit out of my depth here, from my experience with other dependency management systems that may be best. Updated.

mojavelinux commented 8 years ago

@johncarl81 The syntax you have used locks the major version, but not the minor version. In other words, if Jekyll 3.2 is released, then ~> 3.1 will match that.

If we want to also lock the minor version, we need an arbitrary third number. In essence, ~> means allow the last number to increment.

So, to lock to Jekyll 3.1, you'd need to type ~> 3.1.0.

That brings us to the question. Should we lock the minor version too, or just the major version? I'm only asking so we're clear what we are setting.

johncarl81 commented 8 years ago

Ah, I should have checked the definition of ~> before making this update. My intention was to lock everything except for the bug-fix portion of the version number. Do you think this is appropriate here?

mojavelinux commented 8 years ago

In that case, we need that extra number. The value doesn't actually matter, so you can just make it "0". It's just a placeholder.

johncarl81 commented 8 years ago

Ok, updated.

mojavelinux commented 8 years ago

Let's merge it!

mojavelinux commented 8 years ago

Thanks!