Closed pomdtr closed 2 years ago
Maybe it's better to convert
```plantuml Alice --> bob ```
to
[plantuml]
....
Alice --> Bob
....
in order to respect asciidoctor-diagram syntax (but does not work with gitlab).
Yes, it should be on a literal block, not a listing block.
Looking good so far!
I don't have any experience in ruby, so this syntax error is kind of cryptic to me ¯\(ツ)/¯
Ok, it seems to work now. Should i add an unit test ?
Yes. Though they aren't really unit tests. They are document tests. You put the input and output and the test suite will verify they match. You can use one of the existing document tests as a reference.
What concerns me a bit about this is the proliferation of diagram names we have to track. That seems like it is going to be a maintenance problem. Is it possible to narrow this down to less names, or is there a place we can get this list of names? Surely Markdown isn't supporting all the same diagram names as Asciidoctor Diagram. Or is it?
Hi, feel free to update the pull requests with the necessary changes.
I fully agree with your feedback, however I do not need this feature anymore, and I don't have much time to resolve the merge conflicts. So I am not sure when or if I will update this.
Have a great day !
Thanks for letting me know. I'll take it from here. Even though I haven't gotten around to merging it yet, thanks for submitting the PR!
Replace by #105.
Closes #76
Please be indulgent, I have never coded in ruby.