No looping in gif as of v1.4.0, regardless of `--no-loop=false`

asciinema / agg

asciinema gif generator

Apache License 2.0

1.12k stars 38 forks source link

No looping in gif as of v1.4.0, regardless of `--no-loop=false` #36

Closed PawelLipski closed 1 year ago

PawelLipski commented 1 year ago

I needed to use ImageMagick (mogrify -loop 0 <gif>) to add looping 🤔

Looping absent both without --no-loop and with --no-loop=false.

For context, I've used the following agg command:

theme=000000,ffffff,000000,ff0000,00ff00,ffff00,00ffff,ff00ff,00ffff,d9d9d9,4d4d4d,ff0000,00ff00,ffff00,00ffff,ff00ff,00ffff,ffffff
agg --speed=0.75 --theme="$theme" \
  --cols=122 --rows=35 \
  --font-size=14 --line-height=1.2 \
  "$cast_path" "$gif_path"

I can provide more details if needed.

LandonTClipp commented 1 year ago

Confirmed that looping behavior works in v1.3.0.

PawelLipski commented 1 year ago

@LandonTClipp can you repro the bug on v1.4.0? I can provide a .cast file + agg command if needed

LandonTClipp commented 1 year ago

Yes the bug happens in 1.4.0 for me. I meant that the bug does not exist in 1.3.0.

Zhengqbbb commented 1 year ago

v1.4.0 gif No looping!

asciinema rec a.cast
echo nice
echo nice
echo nice
echo end
exit
agg a.cast a.gif

aaaa

ku1ik commented 1 year ago

Hmmkay, this should be easy fix.

ku1ik commented 1 year ago

Fixed in 1.4.1.