Open hartwork opened 11 months ago
So the main problem is the recorder put 0x0 size in the cast file, which we should prevent from happening in the first place. But I think it's a good idea to add a check here in agg and bail if any of the dimensions is lower non-positive.
Describe the bug Hi! Thanks for making asciinema and agg and sharing them as Software Libre! :pray:
I recorded some cast file with asciinema 2.3.0, fed it to agg and it panicked. Note the
"width": 0, "height": 0
, those were produced by asciinema from……in the environment at recording time.
So now for the crashing agg:
To Reproduce
~/.cargo/bin/agg bug.cast.txt out.gif
Expected behavior No panic
Versions:
https://github.com/asciinema/agg#ec02812e
) — https://github.com/asciinema/agg/commit/ec02812eAdditional context Please see description