search

asciinema / asciinema-server

Platform for hosting and sharing terminal session recordings
https://asciinema.org
Apache License 2.0
2.26k stars 262 forks source link

On website, some lines are partially covered #390

Closed DUOLabs333 closed 1 year ago

DUOLabs333 commented 2 years ago

Arch Linux with Firefox. For some reason, each of the lines are hidden partially.

Example: https://asciinema.org/a/476732

image

ku1ik commented 2 years ago

It happens so that I use Arch and Firefox too :) This is how it looks for me:

image

Looks like the font measurement doesn't work in your case for some reason :thinking: Do you experience this for all the recordings on asciinema.org?

DUOLabs333 commented 2 years ago

Yes, no matter what page I use, even if it's embedded.

ku1ik commented 2 years ago

Ok. Let's check what font is actually used for rendering in your case. Can you inspect one of the lines with text in the player and then switch to the Fonts inspect as seen here?

image

DUOLabs333 commented 2 years ago

For my example, it uses Noto Sans Mono.

DUOLabs333 commented 2 years ago

This is probably due to the fact that I set a global font size minimum of 18.

ku1ik commented 2 years ago

Interesting. I assume you did that via fontconfig. Can you show the snippet so I can reproduce?

Either way I don't think it's going to be easy (possible) to fix...

DUOLabs333 commented 2 years ago

I just set it in Preferences.

ku1ik commented 2 years ago

Got it, thanks.

This problem is not fixable in the current text-based renderer. We can keep this issue open for the time being though.