search

asciinema / asciinema-server

Platform for hosting and sharing terminal session recordings
https://asciinema.org
Apache License 2.0
2.26k stars 262 forks source link

Font related improvements #412

Closed ku1ik closed 1 year ago

ku1ik commented 1 year ago

This exposes player's terminalLineHeight in the form of a number input on the recording settings page, which addresses:

Also allows selecting Nerd Font (Fira Code or JetBrains Mono) instead of default font for a recording, which addresses:

skonik commented 1 year ago

Awesome

jonpetersathan commented 3 months ago

Any chance we can get this in the self-hosted version as well? Or is there an option to configure this manually via custom.exs?

ku1ik commented 3 months ago

Hey @jonpetersathan, this is included in the self-hosted version. You don't see those new options in the recording settings form?

jonpetersathan commented 3 months ago

@ku1ik Ah yeah, sorry, there I do see the settings indeed! But is there a way to change the default settings? Like you can on https://asciinema.org/user/edit, because on the self hosted version, I can only change the terminal theme in the user settings form.

Edit: Ah I think I know why, I assume this isn't available yet, in the latest docker image: #431 - got it now, thanks! In that case I will create my own image for now.

ku1ik commented 3 months ago

I've released new version yesterday: https://github.com/asciinema/asciinema-server/releases/tag/v20240324

And yes, there's no global setting (yet), but I plan to add it.

jonpetersathan commented 3 months ago

@ku1ik: With the new version, I can know see the settings per user. Thanks! I also tried to make NerdFonts work in iframes and created a pull request: #434.