search

ascmitc / mhl

ASC Media Hash List
MIT License
58 stars 8 forks source link

Write multiple hash algorithms in one `create` pass broken? #112

Closed Scott-Larsen closed 2 years ago

Scott-Larsen commented 2 years ago

In an e-mail to Jon Waggoner asking whether it's possible to output multiple hash algorithms in a single .mhl file he seems to indicate that it's possible but may be broken. If it is possible, especially if it's working, it would be great to have an example in the Readme of how to properly call multiple algorithms. I tried to dig through the code as a junior developer, unfamiliar with the project but the multiple=False, on line 50 of commands.py had me thinking it wasn't possible. Thanks for all your work on this, everyone.

jwaggs commented 2 years ago

@Scott-Larsen thanks for opening the issue. You are correct - multiple has been disabled via line 50 of commands.py.

We have a meeting on Wednesday at 5:30pm PDT - I'll bring this up during the meeting. I think this is one of those features that got sidelined til "later" - and that time has finally arrived. Would be good to get this fixed.

I looked under the hood a bit and there are several sections of code that would need refactoring to support this.

If you end up digging any deeper, feel free to open a pull request. I likely won't be able to take a stab at fixing this for a few weeks considering my current workload.

ptrpfn commented 2 years ago

FYI: @mthudgins is working on this already in branch dev/multiple-checksum-output.

ptrpfn commented 2 years ago

Is resolved and merged.