Closed jmccdev closed 2 years ago
@ptrpfn I think we should comb through the code to remove any assertion statements in favor of raising explicit errors if they cannot be handled.
I like to limit assertions to test cases.
@jmccdev Can you add the invocation (params, paths etc.) of the ascmhl create
command? Everything that helps reproducing it would be good.
original post updated with the command
The reason for the crash was in test case 105b. Currently the ascmhl
tool did catch the case if a mhl file has a different hash than the hash noted in a hash reference, but it simply asserted instead of displaying an error.
The problem:
MHL file sources/nested_histories/105b/16421225_Day001/ascmhl/0001_16421225_Day001_2022-02-09_040703.mhl
references
MHL file sources/nested_histories/105b/16421225_Day001/Camera_Media/A007_0124J4/ascmhl/0002_A007_0124J4_2022-02-09_040703.mhl
with a c4 hash of
c43Tp4c9dPJv4or8D35tzSNNPqSdW9DxZX5ZG7qSp9jnqetKTAfUVCEHWXvBX9xNEzpmeM9uBtai7fswWPBfs8wvkW
but the actual hash of the file 0002_A007_0124J4_2022-02-09_040703.mhl
is
c434WT7GH925LAHEeSwmJppq1WMT7EPD5FpFRZdWpq2j2Ejsapb4kW2xn3JrmUmY3sS2GgoFAXUiQQo8K6GXmVJGrm
.
Pull request PR #117 fixes the issue by adding error log in case this happens and doesn't assert any more.
TBD: Decide if the tool should abort or continue (in PR #117 it continues), and what the exit code should be. Added this topic to agenda of the the next group meeting.
Fixed with PR #117.
Files are available under the ASC MHL G-Drive, under 'Test-Media > Interop Test Cases':