Adding support for multiple checksum formats for create command

[ptrpfn]

• Switching on "multiple=True" for "-h" option
• Necessary refactoring and extension of hasher and command methods
• Solves issue #112

[ptrpfn]

@mthudgins There is something weird going on in my tests with two hash formats: For example, when you remove the -n option in test_create_mulitple_hashformats, a c4 hasher tries to interpret a md5 hash (and runs out of hex characters). I also tried to run something similar on a folder with ascmhl create -v -h md5 -h sha1 /Users/ptr/Desktop/B002R2EC_temp which also failed. Is there a test that invokes the directory hashing with multiple hash formats successfully? I hope I didn't miss anything.

[mthudgins]

I look into this and get back to you

On Mon, Mar 7, 2022 at 9:29 AM Patrick Renner @.***> wrote:

@mthudgins https://github.com/mthudgins There is something weird going on in my tests with two hash formats: For example, when you remove the -n option in test_create_mulitple_hashformats, a c4 hasher tries to interpret a md5 hash (and runs out of hex characters). I also tried to run something similar on a folder with ascmhl create -v -h md5 -h sha1 /Users/ptr/Desktop/B002R2EC_temp which also failed. Is there a test that invokes the directory hashing with multiple hash formats successfully? I hope I didn't miss anything.

— Reply to this email directly, view it on GitHub https://github.com/ascmitc/mhl/pull/120#issuecomment-1060747412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWEAHIYJ4TRJET4Q4YTZTDU6YHDHANCNFSM5OVEG6CA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Mark Hudgins Lead Software Engineer Imagine Products

[ptrpfn]

I look into this and get back to you …

Looks good now! I adjusted a few more tests for directory hashes to also check multiple hash formats and adjusted the stdout output a bit for a cleaner log.

[ptrpfn]

Looks good to me, ready to merge!