search

ascoders / react-native-image-viewer

🚀 tiny & fast lib for react native image viewer pan and zoom
MIT License
2.44k stars 578 forks source link

Warning: componentWillMount has been renamed, and is not recommended for use #360

Open ghost opened 4 years ago

chetan-zalake commented 4 years ago

Any updates on this?

r0b0t3d commented 4 years ago

358 It is merged but not released yet

devaublanc commented 4 years ago

Hi ! @ascoders can we release please ? 🙏

jaredegan commented 4 years ago

👍

Tamenze commented 4 years ago

+1

Trashpants commented 4 years ago

looking at whats happening with this package, the solve has actually been rolled out on this side but as @ascoders has a dependency on https://github.com/ascoders/react-native-image-zoom this hasn't actually had any of the fixes applied.

Fixing that would in turn fix this I believe

LuongTruong commented 4 years ago

is there any updates on this issue? I have the warning too after updating to react native 61.

Many thanks guys

gsantiago commented 4 years ago

@ascoders please, can you release the merged PR? Thanks

claudiozam commented 4 years ago

Hi ! @ascoders can we release?

Egizas commented 4 years ago

@ascoders can we get a release?

davx1992 commented 4 years ago

@ascoders still see error. Warning: componentWillMount has been renamed Is it possible to fix this?

cklinx commented 4 years ago

Same here

yaron1m commented 4 years ago

@ascoders Can you please release a new version?

gerryfletch commented 4 years ago

Would like to see this merged too :)

felipebergamin commented 4 years ago

still getting this error on v2.2.27

andelh commented 4 years ago

+1 for merge :)

Spoutnik97 commented 4 years ago

+1 for a new release please :) @ascoders

alendra1945 commented 4 years ago

+1 for a new release @ascoders

ascoders commented 4 years ago

Sorry for late reply, due to the large changes, major version upgrade is adopted to prevent the break change. react-native-image-zoom-viewer@3.0.0 is now released!

By the way, anyone want to be a backup maintainer?

sjuanati commented 4 years ago

react-native-image-zoom-viewer@3.0.0 is actually giving 2 warnings:

ComponentWillReceiveProps has been renamed, and is not recommended for use. ComponentWillMount has been renamed, and is not recommended for use.

ArtemKolichenkov commented 4 years ago

Hey guys, I'm a new maintainer for this repo and I'm trying to resolve most common issues right now. Read more in #396. It still might take time to make into release, but at least I can say that next release is soon (like a week or so). I will notify people here to update once the new version is out.

LuongTruong commented 4 years ago

Hello @ArtemKolichenkov , thank you for being a maintainer for this project. How are things going, bro?

ArtemKolichenkov commented 4 years ago

@LuongTruong Hi! I was quite busy this summer unfortunately, sorry for dropping out. Today is my last day at current job, I will wrap things up over here and come back to this repo. Again, sorry for disappearing in summer, had to move and change jobs and bunch of other things 🙁

1sanguk commented 3 years ago

This warning shows up in React Native newer version. React Native homepage provides that those life cycles will be removed after newer upgrade, so it suggest you to use UNSAFE keywords or move methods to the other function. I just solved it by ignoring yellow box or warning. Look up this document: https://ko.reactjs.org/docs/react-component.html