search

ascoders / react-native-image-viewer

🚀 tiny & fast lib for react native image viewer pan and zoom
MIT License
2.45k stars 580 forks source link

Pass useNativeDriver down to react-native-image-pan-zoom #397

Open pxpeterxu opened 4 years ago

pxpeterxu commented 4 years ago

Follow-up to https://github.com/ascoders/react-native-image-zoom/pull/128 and https://github.com/ascoders/react-native-image-viewer/pull/394

Important: This PR assumes that react-native-image-pan-zoom will be released with version 3.0.0 (a major version bump), but please edit it to whatever it ends up getting released as.

警告：这个 PR 假设新的 react-native-image-pan-zoom 的版号是 3.0.0。如果不是的话，请改！

Now that we can specify useNativeDriver in react-native-image-pan-zoom, we need to pass down the prop to <ImageZoom /> too.

因为我们加了 useNativeDriver prop，我们也要把它提供给 ImageZoom -- 他也有分别的动画。

fangasvsass commented 4 years ago

any update?

pxpeterxu commented 4 years ago

I've updated this merge request to require the latest release of react-native-image-pan-zoom, since that's the only version that supports useNativeDriver right now