Clean up with newer Typescript, Prettier, and lint rules - Githubissues

ascoders / react-native-image-viewer

🚀 tiny & fast lib for react native image viewer pan and zoom

MIT License

2.44k stars 577 forks source link

Clean up with newer Typescript, Prettier, and lint rules #411

Open pxpeterxu opened 4 years ago

pxpeterxu commented 4 years ago

Motivation

@ArtemKolichenkov mentioned in https://github.com/ascoders/react-native-image-viewer/issues/396 that the first step to getting this package in order is updating tooling. This merge requests does it!

Changes

This is almost a complete mirror of https://github.com/ascoders/react-native-image-zoom/pull/130:

Upgrade Typescript, ESLint, and Prettier
Apply rules and fix wherever they had errors (e.g., change any types)

Testing

Ran the Demo app and made sure it still worked:

(Also, pretty much all the changes to the library are types-only changes, and should not affect function)

@ArtemKolichenkov : can you take a look? Afterwards, we'd love to get https://github.com/ascoders/react-native-image-viewer/pull/397 and https://github.com/ascoders/react-native-image-viewer/pull/399 reviewed, if you have a chance!

With require('./local.png')

Screen capture

With URL

Screen capture