search

ascoders / react-native-image-viewer

🚀 tiny & fast lib for react native image viewer pan and zoom
MIT License
2.44k stars 576 forks source link

loadImage when going back and forth with arrows #442

Open cooperjbrandon opened 3 years ago

cooperjbrandon commented 3 years ago

When rendering left and right arrows, on tapping the arrow, either this.goBack() or this.goNext() is called. See current implementation:

            <TouchableWithoutFeedback onPress={this.goBack}>
              <View>{this!.props!.renderArrowLeft!()}</View>
            </TouchableWithoutFeedback>

However, in this.goBack and this.goNext, this.loadImage is never called. So no image is shown. This isn't a problem when doing the actual swipe gesture, because when using the swipe gesture, this.handleHorizontalOuterRangeOffset is invoked, which calls this.loadImage.

So now, pressing the arrows loads the image.

jwesselink commented 3 years ago

Ah nice! I was running into the same issue

HenryDeLange commented 3 years ago

Is there an official release available containing this fix?

Looking at v3.0.1 it was released on 19 May 2020 (https://github.com/ascoders/react-native-image-viewer/releases/tag/v3.0.1). But this commit was from 11 Dec 2020.

noway commented 2 years ago

Can this please be merged? I'm experiencing the same issue