search

ascoders / react-native-image-zoom

react native image pan and zoom
MIT License
639 stars 282 forks source link

Add optional hardware texture rendering on Android #112

Closed alexandrius closed 4 years ago

alexandrius commented 5 years ago

This is useful if you want to rotate the rendered image. If renderToHardwareTextureAndroid is enabled image frame cuts of the content for image rotated with transform.

These are screenshots for both enabled and disabled renderToHardwareTextureAndroid https://imgur.com/a/0ucJbtW

ArtemKolichenkov commented 4 years ago

Thanks for the contribution! This actually closes #106

Unfortunately this PR has conflicts now. Can you resolve it? 🙂

I will apply your fix myself in case you don't follow this repo anymore (trying to fix bugs ASAP here, read #129 if interested). Though I will make sure to mark your contributions once I have allcontributors bot installed in this repo.

alexandrius commented 4 years ago

@ArtemKolichenkov Fixed

ArtemKolichenkov commented 4 years ago

Great! Merging this :)

alexandrius commented 4 years ago

@ArtemKolichenkov Any chance of updating https://github.com/ascoders/react-native-image-viewer with updated react-native-image-zoom?

ArtemKolichenkov commented 4 years ago

@alexandrius yes. I will do it as soon as I have time, which is either later today or tomorrow :)

ArtemKolichenkov commented 4 years ago

@all-contributors please add @alexandrius for code

allcontributors[bot] commented 4 years ago

@ArtemKolichenkov

I've put up a pull request to add @alexandrius! :tada:

ArtemKolichenkov commented 4 years ago

@alexandrius just released https://github.com/ascoders/react-native-image-viewer v 3.0.1 with updates from this repo.