search

ascoderu / xtarfile

Wrapper around tarfile to add support for more compression formats
Apache License 2.0
8 stars 5 forks source link

xtarfile.open does not support encoding option #3

Closed jelly closed 4 years ago

jelly commented 4 years ago

For example the following code is not supported:

tarfile.open(package, mode='r', encoding='utf-8')
c-w commented 4 years ago

Thanks for reporting the issue. Could you provide some steps to reproduce the behavior?

Currently xtarfile.open captures extra arguments and passes them to the underlying compressors such as TarFile (see code and list of supported arguments) or ZStandard (see code and list of supported arguments). What is the behavior you'd expect in this situation?

jelly commented 4 years ago

Hmm not sure what is expected, for use case we actually managed to be able to remove the encoding argument and keep it working.

Feel free to close the issue.