search

ascopes / protobuf-maven-plugin

Modern Protobuf and gRPC integration with Maven, with support for custom binary and pure Java protoc plugins.
https://ascopes.github.io/protobuf-maven-plugin/
Apache License 2.0
30 stars 8 forks source link

GH-438: Inline the proto archive extractor #447

Closed ascopes closed 3 weeks ago

ascopes commented 3 weeks ago

The archive extractor is only used in a single place and the concerns can be merged to reduce duplicate code.

This will also allow for supporting incremental compilation in a cleaner way elsewhere.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (a130f0d) to head (0fc687f). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...otobufmavenplugin/sources/ProtoSourceResolver.java 97.06% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #447 +/- ## ========================================== - Coverage 87.71% 87.61% -0.09% ========================================== Files 33 32 -1 Lines 1122 1113 -9 Branches 76 76 ========================================== - Hits 984 975 -9 Misses 104 104 Partials 34 34 ``` | [Files with missing lines](https://app.codecov.io/gh/ascopes/protobuf-maven-plugin/pull/447?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ashley) | Coverage Δ | | |---|---|---| | [...otobufmavenplugin/sources/ProtoSourceResolver.java](https://app.codecov.io/gh/ascopes/protobuf-maven-plugin/pull/447?src=pr&el=tree&filepath=protobuf-maven-plugin%2Fsrc%2Fmain%2Fjava%2Fio%2Fgithub%2Fascopes%2Fprotobufmavenplugin%2Fsources%2FProtoSourceResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ashley#diff-cHJvdG9idWYtbWF2ZW4tcGx1Z2luL3NyYy9tYWluL2phdmEvaW8vZ2l0aHViL2FzY29wZXMvcHJvdG9idWZtYXZlbnBsdWdpbi9zb3VyY2VzL1Byb3RvU291cmNlUmVzb2x2ZXIuamF2YQ==) | `83.06% <97.06%> (+5.01%)` | :arrow_up: |