search

ascopes / protobuf-maven-plugin

Modern Protobuf and gRPC integration with Maven, with support for custom binary and pure Java protoc plugins.
https://ascopes.github.io/protobuf-maven-plugin/
Apache License 2.0
30 stars 8 forks source link

Compute source and dependency hashes in parallel for incremental compilation #468

Closed ascopes closed 1 week ago

ascopes commented 1 week ago

A small optimisation for projects that both have a large number of sources and a large number of dependencies.

Rather than computing all dependency hashes and then all source hashes separately, both are now computed at the same time.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.47%. Comparing base (98ab173) to head (4a52945). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #468 +/- ## ========================================== - Coverage 87.50% 87.47% -0.02% ========================================== Files 37 37 Lines 1255 1252 -3 Branches 91 91 ========================================== - Hits 1098 1095 -3 Misses 119 119 Partials 38 38 ``` | [Files with missing lines](https://app.codecov.io/gh/ascopes/protobuf-maven-plugin/pull/468?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ashley) | Coverage Δ | | |---|---|---| | [...n/sources/incremental/IncrementalCacheManager.java](https://app.codecov.io/gh/ascopes/protobuf-maven-plugin/pull/468?src=pr&el=tree&filepath=protobuf-maven-plugin%2Fsrc%2Fmain%2Fjava%2Fio%2Fgithub%2Fascopes%2Fprotobufmavenplugin%2Fsources%2Fincremental%2FIncrementalCacheManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ashley#diff-cHJvdG9idWYtbWF2ZW4tcGx1Z2luL3NyYy9tYWluL2phdmEvaW8vZ2l0aHViL2FzY29wZXMvcHJvdG9idWZtYXZlbnBsdWdpbi9zb3VyY2VzL2luY3JlbWVudGFsL0luY3JlbWVudGFsQ2FjaGVNYW5hZ2VyLmphdmE=) | `92.11% <100.00%> (-0.29%)` | :arrow_down: |

🚨 Try these New Features: