search

ascorbic / unpic

Universal image CDN translator
https://unpic.pics/lib
283 stars 31 forks source link

Scene7 transformer #42

Closed brianbento closed 1 year ago

brianbento commented 1 year ago

Added the upscale option to the fit parameter so that images scale properly

ascorbic commented 1 year ago

Can you explain what the difference is with this option?

brianbento commented 1 year ago

@ascorbic The fit parameter won't expand the image past it's original size unless upscaling is set to 1, so fit=crop,1 is what will generate the expected behaviour when layout is set to full width.

ascorbic commented 1 year ago

Ah, gotcha. The current behaviour is what we want. We don't want it to scale beyond its original size, as we don't want it to send needlessly large images. We handle the upscaling in the browser instead.

ascorbic commented 1 year ago

Closing for the reason given. If I've misunderstood and this is needed let me know and i can reopen