feat: add KeyCDN support

ascorbic / unpic

Universal image CDN translator

https://unpic.pics/lib

283 stars 31 forks source link

feat: add KeyCDN support #43

Closed tiptenbrink closed 1 year ago

tiptenbrink commented 1 year ago

Hi! This should add support for KeyCDN to unpic. Let me know if anything's missing from the tests / code.

ascorbic commented 1 year ago

Great. Just one copy+paste error. Also, could you add a sample image to the end of the list in examples.json? Thanks!

tiptenbrink commented 1 year ago

Great. Just one copy+paste error. Also, could you add a sample image to the end of the list in examples.json? Thanks!

@ascorbic Ah apologies about that! I think everything should be good now. One question though, should it always center the crop if the width/height don't match the image aspect ratio? By default it doesn't do that on KeyCDN but I could change it so that would be the default behavior.

ascorbic commented 1 year ago

That's great, thanks! The current cropping approach looks great. The only improvement would be, if it supports it, prevent up-scaling images. Generally the approach we want for the default behaviour is:

maintain aspect ratio (this is required)
use "cover" strategy (i.e. the image is cropped to fit the aspect ratio, rather than padded. also required)
use the CDN's "best" focus strategy. Some have smart cropping. The current behaviour looks good.
no upscaling. better to do that in the browser