search

ascorbic / unpic

Universal image CDN translator
https://unpic.pics/lib
291 stars 34 forks source link

feat: add support for imageengine cdn #66

Closed RohanRaina513 closed 1 year ago

ascorbic commented 1 year ago

Thanks for the contribution! The demo images don't seem to be working. Can you check the URLs are correct?

ascorbic commented 1 year ago

@RohanRaina513 Thanks for updating this. The image is giving me an error in the playground if you select ImageEngine: https://deploy-preview-66--unpic-playground.netlify.app/

RohanRaina513 commented 1 year ago

@ascorbic Thanks for pointing it out. This commit should resolve the playground error

ascorbic commented 1 year ago

Hey! Thanks for fixing that, but it seems that we do need the fit arg. Right now it's giving the wrong aspect ratio: if I choose dimensions with a different aspect ratio it doesn't return the correct dimensions. Try it by changing the height in the playground to 300 and you'll see the image go very low res because it's generated the wrong aspect ratio and needed to stretch it to fit.

ascorbic commented 1 year ago

@RohanRaina513 thanks for updating this. It looks like it's working! Are you ready for me to merge this, or is there more to do?

RohanRaina513 commented 1 year ago

@RohanRaina513 thanks for updating this. It looks like it's working! Are you ready for me to merge this, or is there more to do?

@ascorbic Nothing more to be added. Kindly go ahead with the merge