Closed jlarmstrongiv closed 8 months ago
Hey! Thanks for this. We just need a few things to get this ready to merge.
As well as the individual comments, framework transformers need to implement delegateUrl. This is needed so that if the user passes a URL with an href that matches another CDN, we use that instead of the local server. Take a look at the Next.js tests for examples.
Sure! I think the delegateUrl
function that next and vercel uses looks good to me, so I moved it to utils
and used it for astro too
Just wanted to say thank you for your help reviewing this PR @ascorbic ๐ great suggestions
I fixed those issues and squashed to a single commit ๐
Hi @ascorbic ๐ please let me know if thereโs anything else I need to fix with this PRโthanks again for reviewing ๐
@ascorbic and @jlarmstrongiv are there any blockers for this PR? I found unpic-img has an astro component, and wanted to use it with the astro assets image endpoint in my project
Thank you @ascorbic ! Your suggestions were very helpful ๐
Closes https://github.com/ascorbic/unpic/issues/93