ascot4fusion / ascot5

ASCOT5 is a high-performance orbit-following code for fusion plasma physics and engineering
https://ascot4fusion.github.io/ascot5/
GNU Lesser General Public License v3.0
31 stars 9 forks source link

Check convergence of heat load on specific wall flag #116

Open linvelgal opened 2 months ago

linvelgal commented 2 months ago

Improve the plotwall_convergence tool to also calculate and plot the convergence of the heat load on a specific item on the wall marked by a flag.

linvelgal commented 2 months ago

@miekkasarki I think this is done. Should I request the merge now so you can check it?

miekkasarki commented 2 months ago

Thank you for the contribution! I can take care of the pull-request and merging (this will be part of the next release).

Two things that I'd like to change if that's ok for you (I can make the changes). Instead of heatloadonflag and averagedheatloadonflag, the function will only include those walltiles defined by flag (all wall tiles are included if flag is None). This way you can also get peakload and lostpower only on those tiles specified by flag.

The other change is that I don't think a sum of wall loads (in units of W/m^2) is a meaningful quantity (or at least I don't know where it would be useful). I'd drop that and keep only the mean heat load.

linvelgal commented 2 months ago

Sure, that all makes sense :) Thank you!