ascot4fusion / ascot5

ASCOT5 is a high-performance orbit-following code for fusion plasma physics and engineering
https://ascot4fusion.github.io/ascot5/
GNU Lesser General Public License v3.0
31 stars 9 forks source link

Markergen support for rho5d distributions. #89

Closed Otsooni closed 9 months ago

Otsooni commented 9 months ago

The current implementation of markergen does not support sampling from rho5d distributions. Important people (me) need this feature, so I will work on it.

I planned to implement it in the same function (markergen.generate) that would automatically make the distinction between distributions from the abscissae labels. However, I didn't know if anyone (like @miekkasarki) had any plans for the function.

miekkasarki commented 9 months ago

It's "proof-of-principle" function/module. Feel free to expand it anyway you like.

Sure it can autodetect the distribution, but the actual implementation could be separated to private functions.

For this particular feature, I think the existing tools take you far. Once you have sampled (rho,phi,theta) coordinates, then use the mapping input__rhotheta2rz to convert those to cylindrical coordinates.